huan233usc opened a new pull request, #2616: URL: https://github.com/apache/iceberg-rust/pull/2616
## Which issue does this PR close? Part of #2559. ## What changes are included in this PR? Takes the `expr` visitors + `spec` subset (11 of the ~17 occurrences). None of these attributes were guarding code that is used in non-test builds yet, so following the approach of #421 / #2514: - **`expr/visitors/strict_metrics_evaluator.rs` / `strict_projection.rs`**: both visitors are only exercised by their own unit tests until delete/overwrite support starts using them (per the existing TODO). Removed all 7 scattered per-item allows and gated the two module declarations behind `#[cfg(test)]` in `visitors/mod.rs`, with a TODO to lift the gate once delete/overwrite support uses them. Their unit tests still compile and run. *(Happy to delete the modules instead if maintainers prefer — they can be restored from git history when needed.)* - **`spec/manifest/writer.rs`**: `add_delete_entry` / `add_existing_entry` are only called from test modules (`transaction/append.rs`, `scan/mod.rs`), so they are now `#[cfg(test)]` and the stale "Remove this allow later" TODOs are dropped. - **`spec/snapshot.rs`**: removed the unused `Snapshot::log()` helper (zero callers; the `.log()` call elsewhere is `ViewVersion::log`) and its now-unused `SnapshotLog` import. - **`spec/values/decimal_utils.rs`**: `decimal_new` is used only from test modules across the crate, so it is now `#[cfg(test)]`. No public API changes — all touched items are crate-internal. ## Are these changes tested? Existing tests cover them: - `cargo check -p iceberg` is warning-free - `cargo test -p iceberg --lib`: 1302 passed, 0 failed - `cargo clippy -p iceberg --all-targets --all-features -- -D warnings` is clean This pull request and its description were written by Isaac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
