huan233usc commented on code in PR #2616: URL: https://github.com/apache/iceberg-rust/pull/2616#discussion_r3398334695
########## crates/iceberg/src/spec/values/decimal_utils.rs: ########## @@ -83,7 +83,7 @@ pub fn try_decimal_from_i128_with_scale(mantissa: i128, scale: u32) -> Result<De /// Create a D128 from i64 mantissa and scale. /// /// This is equivalent to rust_decimal's `Decimal::new`. -#[allow(dead_code)] +#[cfg(test)] Review Comment: Removing the attribute triggers warning: function decimal_new is never used — decimal_utils is a pub(crate) module and decimal_new isn't re-exported, so the compiler doesn't treat it as public API. Kept the `#[allow(dead_code)]` for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
