blackmwk commented on code in PR #2616: URL: https://github.com/apache/iceberg-rust/pull/2616#discussion_r3394658095
########## crates/iceberg/src/spec/values/decimal_utils.rs: ########## @@ -83,7 +83,7 @@ pub fn try_decimal_from_i128_with_scale(mantissa: i128, scale: u32) -> Result<De /// Create a D128 from i64 mantissa and scale. /// /// This is equivalent to rust_decimal's `Decimal::new`. -#[allow(dead_code)] +#[cfg(test)] Review Comment: We don't need to add this? A public api doesn't not need `#[allow(dead_code)]` ########## crates/iceberg/src/expr/visitors/mod.rs: ########## @@ -24,5 +24,8 @@ pub(crate) mod page_index_evaluator; pub(crate) mod predicate_visitor; pub(crate) mod rewrite_not; pub(crate) mod row_group_metrics_evaluator; +// TODO: Remove the `cfg(test)` once delete/overwrite support starts using the strict visitors. +#[cfg(test)] Review Comment: No, I don't think we should change to current unused functions to test codes, it would be confusing and difficult to main. We should keep the `#[allow(dead_code)]` if they are not actually used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
