huan233usc commented on PR #2616:
URL: https://github.com/apache/iceberg-rust/pull/2616#issuecomment-4683866278
> Thanks @huan233usc for this pr, but we can't simply move currently unused
code to test configuration. Let's keep the `#[allow(dead_code)]` if they are
not actually used.
Sorry for the confusion — I previously read the issue as eliminating every
#[allow(dead_code)] (hence gating the still-unused code behind #[cfg(test)]),
rather than only dropping the attributes that are no longer needed. I've
reverted all the cfg(test) changes and updated the PR:
- Removed the stale #[allow(dead_code)] on
PopulatedDeleteFileIndex::global_equality_deletes — the field is now read by
live code, so the attribute is no longer needed.
- Removed the unused Snapshot::log() helper (zero callers and added long
ago).
- Everything else (strict visitors, manifest writer entries, decimal_new)
keeps its #[allow(dead_code)] since that code is still unused.
I also audited all 15 remaining occurrences in the crate by removing each
attribute and running cargo check --all-features — the one above was the only
stale one; the rest still trigger dead_code warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
