thswlsqls opened a new pull request, #16873: URL: https://github.com/apache/iceberg/pull/16873
<!-- No issue: minor bug fix, issue not required --> ## Summary - The LakeFormation temp-table paths in `GlueTableOperations` (`createGlueTempTableIfNecessary`, `cleanupGlueTempTableIfNecessary`) did not pass `catalogId`, so a non-default `glue.id` targeted the default catalog instead of the configured one. - Added `.catalogId(awsProperties.glueCatalogId())` to both the `CreateTableRequest` and `DeleteTableRequest`. - Every other Glue call already sets it: `getGlueTable`, `persistGlueTable` in the same class, and all `GlueCatalog` calls. - Same fix shape as merged PR https://github.com/apache/iceberg/pull/6223. ## Testing done - Added `TestGlueTableOperations` with 3 cases: create and delete requests carry the configured `glue.id`, and `catalogId` is null when `glue.id` is unset. - `./gradlew :iceberg-aws:test --tests "org.apache.iceberg.aws.glue.TestGlueTableOperations"` — 3 tests passed. - `./gradlew :iceberg-aws:spotlessCheck :iceberg-aws:checkstyleMain :iceberg-aws:checkstyleTest` — passed. - Full `:iceberg-aws:check` not run: it pulls in testcontainers/Docker and real-AWS integration tests not available in this environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
