thswlsqls commented on code in PR #16873:
URL: https://github.com/apache/iceberg/pull/16873#discussion_r3444643031
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -224,12 +224,14 @@ protected static FileIO initializeFileIO(Map<String,
String> properties, Object
}
}
- private boolean createGlueTempTableIfNecessary(TableMetadata base, String
metadataLocation) {
+ @VisibleForTesting
+ boolean createGlueTempTableIfNecessary(TableMetadata base, String
metadataLocation) {
if (awsProperties.glueLakeFormationEnabled() && base == null) {
// LakeFormation credential require TableArn as input，so creating a
dummy table
// beforehand for create table scenario
glue.createTable(
CreateTableRequest.builder()
+ .catalogId(awsProperties.glueCatalogId())
Review Comment:
Thanks @ebyhr — the interceptor is the better fix: it covers the same
CreateTableRequest/DeleteTableRequest calls plus every other site at once,
and
the throw-on-unknown guard kills the root cause. Happy to close this in
favor of
#16875 — or keep it as a stopgap until that lands, whichever you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
