thswlsqls commented on code in PR #16873:
URL: https://github.com/apache/iceberg/pull/16873#discussion_r3444643031
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -224,12 +224,14 @@ protected static FileIO initializeFileIO(Map<String,
String> properties, Object
}
}
- private boolean createGlueTempTableIfNecessary(TableMetadata base, String
metadataLocation) {
+ @VisibleForTesting
+ boolean createGlueTempTableIfNecessary(TableMetadata base, String
metadataLocation) {
if (awsProperties.glueLakeFormationEnabled() && base == null) {
// LakeFormation credential require TableArn as input，so creating a
dummy table
// beforehand for create table scenario
glue.createTable(
CreateTableRequest.builder()
+ .catalogId(awsProperties.glueCatalogId())
Review Comment:
Thanks @ebyhr — the interceptor is the better fix. It handles the same
CreateTableRequest/DeleteTableRequest calls this PR touched, plus all the
other
call sites in one place, and the throw-on-unknown-request guard means a new
Glue
request type can't silently miss the catalog ID again. That removes the root
cause, not just this instance.
Happy to close this in favor of #16875. Let me know if you'd instead prefer
to
keep it as a small stopgap until #16875 lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
