thswlsqls commented on code in PR #16873:
URL: https://github.com/apache/iceberg/pull/16873#discussion_r3472544950
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -224,12 +224,14 @@ protected static FileIO initializeFileIO(Map<String,
String> properties, Object
}
}
- private boolean createGlueTempTableIfNecessary(TableMetadata base, String
metadataLocation) {
+ @VisibleForTesting
+ boolean createGlueTempTableIfNecessary(TableMetadata base, String
metadataLocation) {
if (awsProperties.glueLakeFormationEnabled() && base == null) {
// LakeFormation credential require TableArn as input，so creating a
dummy table
// beforehand for create table scenario
glue.createTable(
CreateTableRequest.builder()
+ .catalogId(awsProperties.glueCatalogId())
Review Comment:
Agreed — let's not merge this as an interim fix if the interceptor makes the
mock-based tests dead weight. The interceptor is the right place to set the
catalog id. Happy to close this in favor of that work, or rework it once the
interceptor lands — your call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
