the-onewho-knocks opened a new pull request, #1321: URL: https://github.com/apache/iceberg-go/pull/1321
**Summary** * add `WithManifestFileFirstRowID`, a `ManifestFileOption` that sets `first_row_id` on a v3+ data manifest * forward variadic `ManifestFileOption` args through `WriteManifest` to `ToManifestFile` **Why** `WriteManifest` predates the v3 work in #735 and forwarded no options to `ToManifestFile`, so `ManifestFile.FirstRowID()` was always `nil` for manifests written through this public helper, even though `ManifestWriter`/`ToManifestFile` already supported setting it via `opts`. Library consumers had no way to set or observe `first_row_id` through `WriteManifest`. `WriteManifest`'s signature change is purely additive (`opts` is the last, variadic parameter), so existing call sites are unaffected. **Testing** * `go test ./... -run '^TestWriteManifestWithFirstRowIDOption$' -count=1` * `go test ./... -count=1` * `gofmt -l .` * `golangci-lint run` Fixes #1274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
