the-onewho-knocks commented on code in PR #1321:
URL: https://github.com/apache/iceberg-go/pull/1321#discussion_r3484935386
##########
manifest.go:
##########
@@ -1274,6 +1274,13 @@ func WithManifestFileContent(content ManifestContent)
ManifestFileOption {
}
}
+// WithManifestFileFirstRowID sets the first_row_id on a v3+ data manifest.
+func WithManifestFileFirstRowID(firstRowID int64) ManifestFileOption {
+ return func(mf *manifestFile) {
+ mf.FirstRowIDValue = &firstRowID
Review Comment:
added the mf.version >= 3 guard in b6f3bbb, with a doc comment noting it's a
no-op on v1/v2 agreed it's worth being explicit here even though
WithManifestFileContent doesn't guard the same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
