the-onewho-knocks commented on code in PR #1321:
URL: https://github.com/apache/iceberg-go/pull/1321#discussion_r3484939333
##########
manifest_test.go:
##########
@@ -1158,6 +1158,66 @@ func (m *ManifestTestSuite)
TestV3DataManifestFirstRowIDInheritanceSkipsDeletedE
m.EqualValues(1000+liveCount, *read[2].DataFile().FirstRowID())
}
+func (m *ManifestTestSuite) TestWriteManifestWithFirstRowIDOption() {
Review Comment:
Added both in b6f3bbb:
a v1 manifest + WithManifestFileFirstRowID case confirming it's a no-op
(FirstRowID() is nil)
a v3 delete-manifest case confirming the field can be set on the manifest
itself (the guard only checks version), but entries don't inherit first_row_id
on read since that's separately gated on content == data in the reader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
