the-onewho-knocks commented on code in PR #1321:
URL: https://github.com/apache/iceberg-go/pull/1321#discussion_r3491541246
##########
manifest.go:
##########
@@ -1274,6 +1274,16 @@ func WithManifestFileContent(content ManifestContent)
ManifestFileOption {
}
}
Review Comment:
moving to WriteManifestV3 resolves the v1/v2 silent-drop issue structurally,
since the function only exists for v3 callers, so there's no toV1() divergence
to worry about. For the delete-manifest case, I'll validate in the function
itself after all options are applied (inside what's currently ToManifestFile),
returning an error if Content == ManifestContentDeletes and a first_row_id was
requested, rather than trying to enforce it from inside a single option closure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
