xanderbailey commented on code in PR #2776:
URL: https://github.com/apache/iceberg-rust/pull/2776#discussion_r3574070729
##########
crates/iceberg/src/catalog/metadata_location.rs:
##########
@@ -83,7 +89,7 @@ impl MetadataLocation {
/// Updates the metadata location with compression settings from the new
metadata.
pub fn with_new_metadata(&self, new_metadata: &TableMetadata) -> Self {
Review Comment:
You may call `with_new_metadata` with a table metadata with a new path
property set and that wouldn't be respected here, is that an issue do we think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
