zakariya-s commented on PR #2776: URL: https://github.com/apache/iceberg-rust/pull/2776#issuecomment-4980755862
Thanks @xanderbailey! I think I've addressed the comment. I did notice though that `write.data.path` isn't fetched from `TableProperties`: https://github.com/apache/iceberg-rust/blob/b80ebbf22f7319f62e21a981f05edbec4783e45e/crates/iceberg/src/writer/file_writer/location_generator.rs#L60-L62 Might create an issue for this later if you think it's worth it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
