andybradshaw commented on code in PR #2776:
URL: https://github.com/apache/iceberg-rust/pull/2776#discussion_r3574299609
##########
crates/iceberg/src/catalog/metadata_location.rs:
##########
@@ -83,7 +89,7 @@ impl MetadataLocation {
/// Updates the metadata location with compression settings from the new
metadata.
pub fn with_new_metadata(&self, new_metadata: &TableMetadata) -> Self {
Review Comment:
Yes, this is definitely an issue (see
https://github.com/apache/iceberg-rust/pull/2776#discussion_r3554676082)... but
wasn't sure if this would be better as a separate fix. Apologies if it was more
churn to suggest that, but figured reviewing [that
diff](https://github.com/apache/iceberg-rust/compare/main...andybradshaw:iceberg-rust:ab/fix-update-table-location)
would be easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
