RussellSpitzer commented on code in PR #17196:
URL: https://github.com/apache/iceberg/pull/17196#discussion_r3590926060
##########
core/src/main/java/org/apache/iceberg/avro/SchemaToType.java:
##########
@@ -30,12 +30,14 @@
class SchemaToType extends AvroSchemaVisitor<Type> {
private final Schema root;
+ private final boolean legacyTimestampMapping;
- SchemaToType(Schema root) {
+ SchemaToType(Schema root, boolean legacyTimestampMapping) {
this.root = root;
if (root.getType() == Schema.Type.RECORD) {
this.nextId = root.getFields().size();
}
Review Comment:
nit: And i'm sorry this isn't in checkstyle, we fight about this alot. But
there should be a linebreak after the } brace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
