rdblue commented on code in PR #17138:
URL: https://github.com/apache/iceberg/pull/17138#discussion_r3590939351
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2561,7 +2565,22 @@ components:
- "is-nan"
- "not-nan"
+ ValueExpression:
+ description: >
+ A value expression per Iceberg Expressions spec, Appendix B: a literal,
+ a field reference, or a function application. The result type is
+ determined when the expression is bound to an input schema.
Review Comment:
I don't think we need to restate parts of the spec here. This is about the
structure and not about how binding or type alignment occurs. I'd omit the
result type part of this since it doesn't matter to the structure.
Also, I don't think that this needs to reference Appendix B. That's a
reference for converting to/from JSON but this is its own spec definition. I
think this is more of a reference to the main body of the spec. Either way,
they say roughly the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
