rdblue commented on code in PR #17138:
URL: https://github.com/apache/iceberg/pull/17138#discussion_r3591062548
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2606,7 +2630,205 @@ components:
child:
$ref: '#/components/schemas/Expression'
+ UnaryPredicate:
+ description: >
+ A predicate that tests a single value expression.
+ type: object
+ additionalProperties: false
+ required:
+ - type
+ - child
+ properties:
+ type:
+ $ref: '#/components/schemas/ExpressionType'
+ enum: ["is-null", "not-null", "is-nan", "not-nan"]
+ child:
+ $ref: '#/components/schemas/ValueExpression'
+
+ ComparisonPredicate:
+ description: >
+ A predicate that compares two value expressions.
+ type: object
+ additionalProperties: false
+ required:
+ - type
+ - left
+ - right
+ properties:
+ type:
+ $ref: '#/components/schemas/ExpressionType'
+ enum: ["lt", "lt-eq", "gt", "gt-eq", "eq", "not-eq", "starts-with",
"not-starts-with"]
+ left:
+ $ref: '#/components/schemas/ValueExpression'
+ right:
+ $ref: '#/components/schemas/ValueExpression'
+
+ SetPredicate:
+ description: >
+ A predicate that operates on a list of literals.
+ type: object
+ additionalProperties: false
+ required:
+ - type
+ - child
+ - values
+ properties:
+ type:
+ $ref: '#/components/schemas/ExpressionType'
+ enum: ["in", "not-in"]
+ child:
+ $ref: '#/components/schemas/ValueExpression'
+ values:
+ $ref: '#/components/schemas/Literals'
+
+ Literal:
+ description: >
+ A literal is either a bare value, an untyped literal object, or a
+ typed literal object.
+ oneOf:
+ - $ref: '#/components/schemas/PrimitiveTypeValue'
+ - type: object
+ additionalProperties: false
+ required:
+ - type
+ - value
+ properties:
+ type:
+ type: string
+ const: "literal"
+ value:
+ $ref: '#/components/schemas/PrimitiveTypeValue'
+ data-type:
+ $ref: '#/components/schemas/PrimitiveType'
+
+ Literals:
+ description: >
+ Literals is either a bare array of literals or a typed object with
+ an explicit data-type applied to all values.
+ oneOf:
+ - type: array
+ items:
+ $ref: '#/components/schemas/Literal'
+ - type: object
+ additionalProperties: false
+ required:
+ - type
+ - values
+ - data-type
+ properties:
+ type:
+ type: string
+ const: "literals"
+ values:
+ type: array
+ items:
+ $ref: '#/components/schemas/PrimitiveTypeValue'
+ data-type:
+ $ref: '#/components/schemas/PrimitiveType'
+
+ FieldReference:
+ description: >
+ A reference to a field. Either a bound reference (by field ID) or
+ an unbound reference (by name). The context in which an expression
+ is used determines which form is valid.
+ oneOf:
+ - $ref: '#/components/schemas/FieldReferenceById'
+ - $ref: '#/components/schemas/FieldReferenceByName'
+
+ FieldReferenceById:
Review Comment:
Why not `IdReference` and `NamedReference`? These names are just a bit
longer than needed. Another alternative is `UnboundReference` and
`BoundReference`. But maybe you're avoiding those names because "bound" might
imply its output type is known?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
