rdblue commented on code in PR #17138:
URL: https://github.com/apache/iceberg/pull/17138#discussion_r3591052848


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2606,7 +2630,205 @@ components:
         child:
           $ref: '#/components/schemas/Expression'
 
+    UnaryPredicate:

Review Comment:
   Similar to my comment below, can we avoid having `UnaryPredicate` and 
`UnaryExpression` (deprecated) by allowing a `term` field here?
   
   I know that this `UnaryPredicate` restricts the `child` field to 
`ValueExpression` and `UnaryExpression` used `Term`, but `Term` should actually 
be a subset of what you can express with `ValueExpression`.
   
   `Term` was a `Reference` (named) or a transform. Both of those can be 
returned as `NamedReference` and `Apply` at read time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to