rdblue commented on code in PR #17138:
URL: https://github.com/apache/iceberg/pull/17138#discussion_r3591150500
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2530,13 +2530,17 @@ components:
Expression:
oneOf:
+ - type: boolean
- $ref: '#/components/schemas/TrueExpression'
- $ref: '#/components/schemas/FalseExpression'
- $ref: '#/components/schemas/AndOrExpression'
- $ref: '#/components/schemas/NotExpression'
- - $ref: '#/components/schemas/SetExpression'
- - $ref: '#/components/schemas/LiteralExpression'
+ - $ref: '#/components/schemas/UnaryPredicate'
+ - $ref: '#/components/schemas/ComparisonPredicate'
+ - $ref: '#/components/schemas/SetPredicate'
- $ref: '#/components/schemas/UnaryExpression'
+ - $ref: '#/components/schemas/LiteralExpression'
+ - $ref: '#/components/schemas/SetExpression'
Review Comment:
Can we rename this to `Predicate`? I think that would be more clear. I think
we are probably also renaming a couple of other structures (assuming that we
combine `UnaryExpression` with `UnaryPredicate` and similar) so we could clean
up quite a bit this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
