rdblue commented on a change in pull request #1820:
URL: https://github.com/apache/iceberg/pull/1820#discussion_r549524028
##########
File path: core/src/main/java/org/apache/iceberg/ManifestReader.java
##########
@@ -136,7 +137,7 @@ public PartitionSpec spec() {
return spec;
}
- public ManifestReader<F> select(Collection<String> newColumns) {
+ public ManifestReader<F> select(List<String> newColumns) {
Review comment:
Why was it necessary to change this to `List` instead of `Collection`?
That's not a binary-compatible change. Couldn't we just make a copy of the
collection if we need the field to be a list? I'm also not sure why `columns`
can't be a `Collection`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
