kbendick commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r555358109
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/BoundLiteralPredicate.java
##########
@@ -69,6 +69,8 @@ public boolean test(T value) {
return cmp.compare(value, literal.value()) != 0;
case STARTS_WITH:
return String.valueOf(value).startsWith((String) literal.value());
+ case NOT_STARTS_WITH:
+ return !String.valueOf(value).startsWith((String) literal.value());
Review comment:
Cool. I agree about being worried re: changing past behavior. Wasn't
entirely sure of all of the conditions around it (I'm not a UTF-8 expert
admittedly), but wanted to bring it up. I'll close this comment then! Thanks
for clarification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
