kbendick commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r555366265
##########
File path: api/src/main/java/org/apache/iceberg/expressions/Evaluator.java
##########
@@ -151,5 +151,10 @@ public Boolean or(Boolean leftResult, Boolean rightResult)
{
public <T> Boolean startsWith(Bound<T> valueExpr, Literal<T> lit) {
return ((String) valueExpr.eval(struct)).startsWith((String)
lit.value());
}
+
+ @Override
+ public <T> Boolean notStartsWith(Bound<T> valueExpr, Literal<T> lit) {
+ return !((String) valueExpr.eval(struct)).startsWith((String)
lit.value());
Review comment:
Ok. That sounds good to me. As I mentioned above to @shangxinli there
are a few places where !startsWith can be substituted.
As I see it currently, they are `ResidualEvaluator` and
`BoundLiteralPredicate`. Should I do the same thing there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
