kbendick commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r555359253
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java
##########
@@ -214,6 +214,11 @@ public Expression or(Expression leftResult, Expression
rightResult) {
return ((String) ref.eval(struct)).startsWith((String) lit.value()) ?
alwaysTrue() : alwaysFalse();
}
+ @Override
+ public <T> Expression notStartsWith(BoundReference<T> ref, Literal<T> lit)
{
+ return ((String) ref.eval(struct)).startsWith((String) lit.value()) ?
alwaysFalse() : alwaysTrue();
+ }
Review comment:
Ok. I agree on fixing it later (if necessary). And the `CharSequence`
recommendation seems much more sane, as that's all the API allows for and then
we reduce allocations.
Thanks for the info, Ryan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
