kbendick commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r555363288
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java
##########
@@ -402,6 +402,11 @@ public Boolean or(Boolean leftResult, Boolean rightResult)
{
return ROWS_MIGHT_NOT_MATCH;
}
+ @Override
+ public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
+ return ROWS_MIGHT_NOT_MATCH;
Review comment:
Cool. I had a note in my working branch about possible cases that could
be handled, but I figured this PR is already large and so I figured that
`ROWS_MIGHT_NOT_MATCH` will definitely give correct results and matches the
surrounding code.
I'lll leave this comment up and open a follow up issue after addressing some
of the comments here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
