aokolnychyi commented on a change in pull request #2048:
URL: https://github.com/apache/iceberg/pull/2048#discussion_r555827619
##########
File path: core/src/main/java/org/apache/iceberg/PropertiesUpdate.java
##########
@@ -89,6 +89,11 @@ public UpdateProperties defaultFormat(FileFormat format) {
newProperties.putAll(updates);
+ // Validate the metrics
+ if (base.schema() != null) {
+
MetricsConfig.fromProperties(newProperties).validateProperties(base.schema());
Review comment:
If we go for a static method, this will also become shorter:
```
MetricsConfig.validateProperties(newProperties, base.schema());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
