holdenk commented on a change in pull request #2048:
URL: https://github.com/apache/iceberg/pull/2048#discussion_r555976757
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopTables.java
##########
@@ -303,6 +304,9 @@ public Table create() {
}
Map<String, String> properties = propertiesBuilder.build();
+ // Validate the metrics
+ MetricsConfig.fromProperties(properties).validateProperties(schema);
Review comment:
I think maybe automatically updating the metrics config on schema
evolution could be a good follow up ticket, WDYT @aokolnychyi ?
I think for this first part requiring that the metrics config is valid
during schema evolution is a good first step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
