aokolnychyi commented on a change in pull request #2048:
URL: https://github.com/apache/iceberg/pull/2048#discussion_r555831586
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopTables.java
##########
@@ -303,6 +304,9 @@ public Table create() {
}
Map<String, String> properties = propertiesBuilder.build();
+ // Validate the metrics
+ MetricsConfig.fromProperties(properties).validateProperties(schema);
Review comment:
@rdblue, will moving the check to the constructor require us to also
update the metrics config when the schema evolves? Otherwise, drop/rename
operations will always fail if the metrics config refers to them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
