holdenk commented on a change in pull request #2048:
URL: https://github.com/apache/iceberg/pull/2048#discussion_r555974043
##########
File path: core/src/main/java/org/apache/iceberg/MetricsConfig.java
##########
@@ -74,6 +75,14 @@ public static MetricsConfig fromProperties(Map<String,
String> props) {
return spec;
}
+ public void validateProperties(Schema schema) {
Review comment:
I'm not sure about having this be a static method since it would end up
constructing an instance of the object anyways, but I don't have strong
feelings here. I lean towards giving it a name like `validateReferencedColumns`
personally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
