smaheshwar-pltr commented on code in PR #17984:
URL: https://github.com/apache/iceberg/pull/17984#discussion_r3995594508


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -219,6 +218,7 @@ the table key parameter (along with existing snapshots) in 
the file, making the
               .map(Lists::newLinkedList)
               .orElseGet(Lists::newLinkedList);
 
+      // Active transactions may still need keys that are not in committed 
metadata.

Review Comment:
   See `transactionCanAppendAfterTableRefresh` which I've added to the 
encryption test suite (that way it'll apply to the future REST change as well) 
for a regression test on this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to