smaheshwar-pltr commented on code in PR #17984:
URL: https://github.com/apache/iceberg/pull/17984#discussion_r3995584156
##########
core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java:
##########
@@ -184,11 +184,21 @@ ByteBuffer encryptedByKey(String manifestListKeyID) {
return unwrappedKeyCache().get(encryptedKeyMetadata.encryptedById());
}
+ /**
+ * @deprecated since 1.12.0, will be removed in 1.13.0; use {@link
+ * #addManifestListKeys(NativeEncryptionKeyMetadata)} instead.
+ */
+ @Deprecated
public String addManifestListKeyMetadata(NativeEncryptionKeyMetadata
keyMetadata) {
+ return addManifestListKeys(keyMetadata).manifestListKey().keyId();
+ }
+
+ /** Registers encrypted manifest-list key metadata and returns it with its
wrapping key. */
+ public ManifestListEncryptionResult
addManifestListKeys(NativeEncryptionKeyMetadata keyMetadata) {
Review Comment:
You're right, I had to change the name because of the overload - now renamed
to something better hopeully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
