gaborkaszab commented on code in PR #18150:
URL: https://github.com/apache/iceberg/pull/18150#discussion_r4035455063


##########
core/src/main/java/org/apache/iceberg/ManifestListWriter.java:
##########
@@ -36,22 +36,21 @@ abstract class ManifestListWriter implements 
FileAppender<ManifestFile> {
   private final FileAppender<ManifestFile> writer;
   private final StandardEncryptionManager standardEncryptionManager;
   private final NativeEncryptionKeyMetadata manifestListKeyMetadata;
-  private final OutputFile outputFile;

Review Comment:
   The only usage of the `outputFile` member outside of the constructor was to 
create a `ManifestListFile` in `toManifestListFile()`, but then it was unused 
later on. Now that the functions are merged, no need for this member



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to