amogh-jahagirdar commented on code in PR #18150:
URL: https://github.com/apache/iceberg/pull/18150#discussion_r4037388135
##########
core/src/main/java/org/apache/iceberg/ManifestListWriter.java:
##########
@@ -36,22 +36,21 @@ abstract class ManifestListWriter implements
FileAppender<ManifestFile> {
private final FileAppender<ManifestFile> writer;
private final StandardEncryptionManager standardEncryptionManager;
private final NativeEncryptionKeyMetadata manifestListKeyMetadata;
- private final OutputFile outputFile;
Review Comment:
Agreed, even if we do my proposed approach we can drop ManifestListFile.
Though in my approach, we would need OutputFile, which I feel like is very
reasonable and consistent with what we do for "regular" manifests
https://github.com/apache/iceberg/blob/f1c6206d8ef4ad92a2a8bab511c5138e1124423e/core/src/main/java/org/apache/iceberg/ManifestWriter.java#L45
. The writer needs to have some reference to an output file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
