amogh-jahagirdar commented on code in PR #18150:
URL: https://github.com/apache/iceberg/pull/18150#discussion_r4037265129
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -356,7 +356,6 @@ public Snapshot apply() {
replacedRecords);
}
- ManifestListFile manifestListFile = writer.toManifestListFile();
this.manifestListEncryptionKeys = writer.encryptionKeys();
Review Comment:
If we do what I mentioned above, I think we can effectively get rid of this
state on SnapshotProducer, and just pass in manifestListFile.encryptionKeys().
So it trades off more state in ManifestListFile for getting rid of state in
SnapshotProducer, which I think is better as as it really shouldn't be
SnapshotProducer's responsibility imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
