gaborkaszab commented on code in PR #18150:
URL: https://github.com/apache/iceberg/pull/18150#discussion_r4037894410
##########
core/src/main/java/org/apache/iceberg/ManifestListWriter.java:
##########
@@ -98,25 +97,16 @@ public Long nextRowId() {
return null;
}
- public ManifestListFile toManifestListFile() {
Review Comment:
Thanks for the feedback, @amogh-jahagirdar !
As you pointed out `SnapshotProducer` is the only user of
`toManifestList()`, but in practice the `ManifestListFile` return type is not
needed there, just the key ID from it. In fact, I'm [working
on](https://github.com/apache/iceberg/pull/17545) dropping this whole
`ManifestListFile` abstraction because there is nothing specific to manifest
files and we need a way to handle manifest files, root manifest, snapshot files
in the same way in term of encryption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
