amogh-jahagirdar commented on code in PR #18725:
URL: https://github.com/apache/iceberg/pull/18725#discussion_r4432784870
##########
core/src/test/java/org/apache/iceberg/TestFilePlanner.java:
##########
@@ -464,6 +464,42 @@ void leafFilesOpenedLazily(FileFormat format) throws
IOException {
}
}
+ @ParameterizedTest
+ @FieldSource("MANIFEST_FORMATS")
+ void leafReportingNoLiveFilesIsPruned(FileFormat format) throws IOException {
Review Comment:
If I'm not mistaken, this only covers a leaf with added files and a
deleted-only leaf, so if `hasLiveFiles` dropped the existing or modified check,
this test would still pass. Could we set up three leaves (one with only added,
one with only existing, one with only modified) and assert all three get
planned, alongside the deleted-only leaf being skipped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
