amogh-jahagirdar commented on code in PR #18725:
URL: https://github.com/apache/iceberg/pull/18725#discussion_r4432793734
##########
core/src/main/java/org/apache/iceberg/FilePlanner.java:
##########
@@ -192,6 +196,16 @@ private TaskContext newTaskContext(int specId) {
ResidualEvaluator.of(spec, filter, caseSensitive));
}
+ private static boolean hasLiveFiles(ManifestFile leaf) {
+ return hasFiles(leaf.addedFilesCount())
Review Comment:
hasModifiedFiles may be a bit awkward (even defaulting to true is weird)
considering it doesn't really apply to older format versions, e.g. what does it
mean for a v1 manifest to have a modified file? But I think at least for
added/existing would be good to use the existing API and then just inline the
check for modified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
