anoopj commented on code in PR #18725:
URL: https://github.com/apache/iceberg/pull/18725#discussion_r4436210311
##########
core/src/main/java/org/apache/iceberg/FilePlanner.java:
##########
@@ -192,6 +196,16 @@ private TaskContext newTaskContext(int specId) {
ResidualEvaluator.of(spec, filter, caseSensitive));
}
+ private static boolean hasLiveFiles(ManifestFile leaf) {
+ return hasFiles(leaf.addedFilesCount())
Review Comment:
Good call, and agree on skipping modified files. Switched to the existing
APIs and inlined the modified check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
