RussellSpitzer commented on code in PR #18252:
URL: https://github.com/apache/iceberg/pull/18252#discussion_r4519007873
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -1155,6 +1155,136 @@ private Map<Integer, NestedField> lazyFieldsById() {
}
}
+ public static final class FileType extends NestedType {
+ public static final String NAME = "file";
+ public static final int NUM_NESTED_FIELDS = 6;
+
+ private static final String URI = "uri";
+ private static final String OFFSET = "offset";
+ private static final String SIZE = "size";
+ private static final String CONTENT_TYPE = "content_type";
+ private static final String CHECKSUM = "checksum";
+ private static final String INLINE = "inline";
+
+ public static FileType of(int baseId) {
Review Comment:
Added Javadoc on of. The mismatch check will be in the Schema constructor in
Part 2.
The callers of FileType.of are:
- ID assignment (applyAssignedId, this PR)
- UpdateSchema when adding a column (Part 2),
- schema JSON parsing (Part 3)
- ORC schema conversion (Part 7, from the field's iceberg.id).
Also i'll just post the rest of the PR's now just incase someone wants to
read ahead but i'll have to keep restacking as we change the earlier parts so
i'll leave all the others as drafts till we get to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
