rdblue commented on code in PR #19007:
URL: https://github.com/apache/iceberg/pull/19007#discussion_r4604284648
##########
core/src/test/java/org/apache/iceberg/TestV4ManifestWriter.java:
##########
@@ -546,6 +620,379 @@ public void rootDataFileFirstRowIdAssignment() throws
IOException {
}
}
+ @Test
Review Comment:
Yeah, I left out a few cases where I thought there were diminishing returns
for adding tests.
Delete files can't be wrapped and there are tests using mocks in
`TestV4TrackedFileWrappers`. I went ahead and added the checks here since I
think this is a good place to reject files and there are other rules that would
otherwise not be visible (raises questions like "why reject DELETE_MANIFEST but
not EQUALITY_DELETES?").
You're right about the delete manifest rejections. I'll go ahead and do the
delete manifest tests in this PR. There aren't really enough for a separate PR;
just 2 simple cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]