rdblue commented on code in PR #19007:
URL: https://github.com/apache/iceberg/pull/19007#discussion_r4604626839
##########
core/src/main/java/org/apache/iceberg/mumbling/MumblingBitmaps.java:
##########
@@ -33,4 +34,35 @@ private MumblingBitmaps() {}
public static ManifestBitmap read(ByteBuffer buffer) {
return new MumblingBitmap(buffer);
}
+
+ /**
+ * Create a new empty mutable bitmap.
+ *
+ * @return a new mutable bitmap with no bits set
+ */
+ public static MutableBitmap newMutableBitmap() {
+ return MumblingBitmaps.newMutableBitmap();
Review Comment:
Coming back to this, the reason for `MumblingBitmaps` rather than adding
factory methods to the `ManifestBitmap` interface is that the bitmap classes
aren't in API, only the interface is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]