rdblue commented on code in PR #19007:
URL: https://github.com/apache/iceberg/pull/19007#discussion_r4604576679


##########
core/src/main/java/org/apache/iceberg/V4ManifestWriter.java:
##########
@@ -113,8 +114,8 @@ private V4ManifestWriter(
 
   protected abstract StructLike prepare(TrackedFile file, Tracking tracking);
 
-  // TODO: add row ID space to spec and ManifestInfo
-  public long assignedRowIds() {
+  @VisibleForTesting
+  long assignedRowIds() {

Review Comment:
   I think this is fine and it's exposed for testing. This is the count of row 
IDs that will be assigned by a root or will be assigned on read. The 
distinction between unassigned for leaf and assigned for root doesn't seem very 
valuable given the scope, and not very valuable even if this were more widely 
exposed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to