rdblue commented on code in PR #19007:
URL: https://github.com/apache/iceberg/pull/19007#discussion_r4604792869


##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -175,7 +175,7 @@ private Function<TrackedFile, TrackedFile> 
applyInheritance() {
         public TrackedFile apply(TrackedFile file) {
           TrackingStruct tracking = (TrackingStruct) file.tracking();
           tracking.inherit(manifest.snapshotId(), manifest.sequenceNumber());
-          if (tracking.assignFirstRowId(nextRowId)) {
+          if (file.contentType() == FileContent.DATA && 
tracking.assignFirstRowId(nextRowId)) {

Review Comment:
   This was needed for the delete manifest tests and I added a test for it in 
`TestV4ManifestReader`. This was not happening for data manifests because a 
first row ID was always assigned at write time.
   
   The reader inheritance tests were for leaf manifests, which is why this 
wasn't caught earlier. Now there is a test for a root manifest with leaf data 
and delete manifests. Those do not inherit values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to