pvary commented on code in PR #18416:
URL: https://github.com/apache/iceberg/pull/18416#discussion_r4617716689


##########
format/spec.md:
##########
@@ -1111,8 +1145,8 @@ Each stats struct holds statistics for one table field. 
It may contain the follo
 
 | Requirement | Offset | Name                      | Type                      
| Included for                                  | Description |
 
|-------------|--------|---------------------------|---------------------------|-----------------------------------------------|-------------|
-| _optional_  | 1      | `lower_bound`             | Field type or `geo_lower` 
| all primitives or `variant`                   | Lower bound stored as the 
field's type, or `geo_lower` for geo types |
-| _optional_  | 2      | `upper_bound`             | Field type or `geo_upper` 
| all primitives or `variant`                   | Upper bound stored as the 
field's type, or `geo_upper` for geo types |
+| _optional_  | 1      | `lower_bound`             | Field type or `geo_lower` 
| `variant` or all primitives except `vector`    | Lower bound stored as the 
field's type, or `geo_lower` for geo types |
+| _optional_  | 2      | `upper_bound`             | Field type or `geo_upper` 
| `variant` or all primitives except `vector`    | Upper bound stored as the 
field's type, or `geo_upper` for geo types |
 | _optional_  | 3      | `value_count`             | `long`                    
| all                                           | Number of values in the 
column (including null and NaN values) |

Review Comment:
   Do we want to specify that vectors `value_count` is the number of the 
non-null vectors?
   It is fairly natural, but might worth to mention, especially as Parquet 
metrics are only collected for leaf elements, so 10 rows and D = 768 give 
num_values = 7680.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to