pvary commented on code in PR #18416:
URL: https://github.com/apache/iceberg/pull/18416#discussion_r4616745954


##########
format/spec.md:
##########
@@ -1934,12 +1971,25 @@ Lists must use the [3-level 
representation](https://github.com/apache/parquet-fo
 | **`binary`**       | `binary`                                                
                                                                                
     |                                             |                            
                                    |
 | **`struct`**       | `group`                                                 
                                                                                
     |                                             |                            
                                    |
 | **`list`**         | `3-level list`                                          
                                                                                
     | `LIST`                                      | See Parquet docs for 
3-level representation.                   |
+| **`vector(E, D)`** | `3-level list`                                          
                                                                                
     | `FINITE_VECTOR(D)`                          | The outer group carries 
the field ID of the vector. When writing, the `element` field must use the 
Parquet type for E listed in the vector element table below. Writing and 
reading an element must preserve its value exactly. The ConvertedType must be 
`LIST`. The `list` and `element` fields must not be assigned field IDs. |
 | **`map`**          | `3-level map`                                           
                                                                                
     | `MAP`                                       | See Parquet docs for 
3-level representation.                   |
 | **`variant`**      | `group` with `metadata` and `value` fields. `metadata` 
and `value` must not be assigned field IDs and the fields are accessed through 
names. | `VARIANT`                                   | See Parquet docs for 
[Variant 
encoding](https://github.com/apache/parquet-format/blob/master/VariantEncoding.md)
 and [Variant shredding 
encoding](https://github.com/apache/parquet-format/blob/master/VariantShredding.md).
 |
 | **`geometry`**     | `binary`                                                
                                                                                
     | `GEOMETRY`                                  | WKB format, see [Appendix 
G](#appendix-g-geospatial-notes).                             |
 | **`geography`**    | `binary`                                                
                                                                                
     | `GEOGRAPHY`                                 | WKB format, see [Appendix 
G](#appendix-g-geospatial-notes).                             |
 | **`file`**         | `group` with the `file` sub-fields. Sub-fields must be 
assigned field IDs.                                                             
      | `FILE`                                      | See Parquet docs for the 
[`FILE` 
type](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#file)
 and [File Type](#file-type). |
 
+Vector elements must be written to Parquet using the following types:
+
+| Element type  | Parquet physical type     | Logical type |
+|---------------|---------------------------|--------------|
+| **`int`**     | `int32`                   |              |
+| **`long`**    | `int64`                   |              |
+| **`float16`** | `fixed_len_byte_array[2]`  | `FLOAT16`    |

Review Comment:
   nit: Fixing the table layout
   ```suggestion
   | **`float16`** | `fixed_len_byte_array[2]` | `FLOAT16`    |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to