rdblue commented on a change in pull request #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r587686585
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -78,6 +78,9 @@ private TableProperties() {
public static final String SPLIT_OPEN_FILE_COST =
"read.split.open-file-cost";
public static final long SPLIT_OPEN_FILE_COST_DEFAULT = 4 * 1024 * 1024; //
4MB
+ public static final String SPLIT_BY_PARTITION = "read.split.by-partition";
Review comment:
I'm also skeptical that this is useful at the table level. It seems like
this would always be something to configure during a scan. You only know that
the table is or is not used in a join in the query engine. And we combine by
default for the 4MB file case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
