sunchao commented on a change in pull request #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r587711111
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -491,6 +491,19 @@ public static int batchSize(Map<String, String>
properties, CaseInsensitiveStrin
TableProperties.PARQUET_BATCH_SIZE,
TableProperties.PARQUET_BATCH_SIZE_DEFAULT));
}
+ public static Boolean propertyAsBoolean(CaseInsensitiveStringMap options,
String property, Boolean defaultValue) {
Review comment:
Yea I thought about it, but since other similar methods like
`propertyAsLong`, `propertyAsInt` all return the boxed version, I did the same.
I can change it for sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
