sunchao commented on a change in pull request #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r587709991
##########
File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
##########
@@ -102,8 +102,8 @@ protected TableScan newRefinedScan(TableOperations ops,
Table table, Schema sche
}
@Override
- protected long targetSplitSize(TableOperations ops) {
- return ops.current().propertyAsLong(
+ public long targetSplitSize() {
+ return tableOps().current().propertyAsLong(
Review comment:
Before `ops` is passed in as parameter, but it seems we always pass
`BaseTableScan.ops` as the argument for it. So instead I removed the parameter
and just directly call `tableOps()` which does the same thing.
Do you think we'll ever need to pass different `TableOperations` other than
``BaseTableScan.ops` for this method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
