sunchao commented on a change in pull request #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r587706364
##########
File path: api/src/main/java/org/apache/iceberg/FileScanTask.java
##########
@@ -47,6 +47,13 @@
*/
PartitionSpec spec();
+ /**
+ * The partition data for the file of this task.
Review comment:
> What does this return if there is no partition?
It will return `BaseFile.EMPTY_PARTITION_DATA`, see changes to
`StaticDataTask.java` for example.
> I think that we should consider adding a struct type that describes this
tuple. That way, we can use an empty struct for unpartitioned and a non-empty
struct for tasks that are combined by partition. We could also support more
combinations, like combining across day partitions by not across bucket
partitions or similar.
Hmm isn't `spec()` above designed for this purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
