rymurr commented on pull request #2399: URL: https://github.com/apache/iceberg/pull/2399#issuecomment-813353404
> @rymurr I believe I got all the issues you mentioned. With the Term hierarchy, I agree it's not ideal, but I played around with a couple of different refactors, and nothing seemed much better. I think a more extensive rewrite would be needed to really reduce the complexity of the class hierarchies. I like the `Protocol` idea, although I think we're supporting py 3.7(...for now anyways...), so maybe something to think about in the next iteration on this module. Cool, I agree with you. Lets get it working then possibly re-write it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
